fix: Use our data set to work out if a module is a node module #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
reviewed
Sep 18, 2024
| const getConfiguredNodeVersion = require("../util/get-configured-node-version") | ||
| const getSemverRange = require("../util/get-semver-range") | ||
| const visitImport = require("../util/visit-import") | ||
| const visitRequire = require("../util/visit-require") | ||
| const mergeVisitorsInPlace = require("../util/merge-visitors-in-place") | ||
| const { | ||
| NodeBuiltinModules, | ||
| } = require("../unsupported-features/node-builtins.js") |
There was a problem hiding this comment.
nits: we could move node-builtins.js to outer - it's now not just used by those rules. :)
There was a problem hiding this comment.
Where do you think we should put the directory?
I was also thinking about going through and merging the no-deprecated-api into the unsupported-features so its all in one place as a consistent data set 🤔
There was a problem hiding this comment.
Where do you think we should put the directory?
maybe /lib/dataset/?
I was also thinking about going through and merging the no-deprecated-api into the unsupported-features
It would be nice if these rules could share data, so we don't have to worry about updating one and forgetting the other.
aladdin-add
approved these changes
Sep 18, 2024
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #337